feat: exit early when failed to parse json spec#423
Open
reversearrow wants to merge 1 commit intopb33f:mainfrom
Open
feat: exit early when failed to parse json spec#423reversearrow wants to merge 1 commit intopb33f:mainfrom
reversearrow wants to merge 1 commit intopb33f:mainfrom
Conversation
reversearrow
force-pushed
the
chore/err_handling_for_invalid_json
branch
from
1ae8227 to
7671aca
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #423 +/- ##
==========================================
- Coverage 99.62% 99.57% -0.06%
==========================================
Files 168 168
Lines 22668 22684 +16
==========================================
+ Hits 22584 22588 +4
- Misses 79 91 +12
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
reversearrow
force-pushed
the
chore/err_handling_for_invalid_json
branch
from
dfd3046 to
f233c95
Compare
reversearrow
changed the title
reversearrow
force-pushed
the
chore/err_handling_for_invalid_json
branch
from
f233c95 to
3d3330c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces an early return on JSON parsing failure to avoid proceeding with invalid input.